[mythtv] [mythtv-commits] mythtv commit: r26111 - in trunk/mythtv by mdean

[Michael T. Dean]

  On 09/04/2010 05:41 AM, mythtv at cvs.mythtv.org wrote:
> Refactor the user interface of the recording cut list editor to take advantage of the new cleaner design of the editor provided by Mark's libmythui-osd code, which ensures users can't create invalid cut lists with discontinuities.  Refs #7916.  Fixes #8564.  Fixes #8832.

FWIW, I still have some planned changes for the cut list editor.

One thing I would like to see, is a sort of "zoom bubble" (a magnified 
view of the current position and one or both surrounding marks) to make 
it easier for the user to see whether to move the next/previous cut, 
since it can be difficult to tell whether you're before or after a cut 
in some cases.  Or perhaps someone with better UI skills could come up 
with a better approach for showing (and theming) the information.  I 
tried to make it as clear as possible with the words (which is why I'm 
using both previous/next /and/ start/end in the descriptions when you're 
not in a cut area), but as Jim S. found, it still requires paying 
attention to what you're doing and taking clues from the rest rest of 
the edit UI--like whether you see the word "cut" or whatever your theme 
displays when in a cut region.

"Enhanced cutpoint edit functionality" ( 
http://svn.mythtv.org/trac/ticket/6322 ), which shows frames around your 
current position, is also a nice idea.  Unfortunately, it's unusable as 
is--someone needs to rewrite it to use MythUI (and to be themable 
however themers would want to theme it.

In addition, I think we still have several key bindings that need 
modification for consistency (all the rest is about key bindings).

I'd like to see a change of the default key list for INVERTMAP and an 
ability to use INFO to display information about the cut list (for 
example, showing a list of cut time codes, total amount cut, total 
program length before and after cutting, or whatever other useful 
information people can imagine wanting while editing).

TV Editing  | INVERTMAP      | Invert Begin/End cut points            | I
Global      | INFO           | More information                       | I

Also, moving around inside the editor is very different from moving in 
TV Playback:

TV Playback | SKIPCOMMBACK   | Skip Commercial (Reverse)             | 
Q,Home
TV Editing  | CLEARMAP       | Clear editing cut points              | 
C,Q,Home
TV Editing  | PREVCUT        | Jump to the previous cut point        | PgUp

and

TV Playback | SKIPCOMMERCIAL | Skip Commercial                       | Z,End
TV Editing  | LOADCOMMSKIP   | Load cut list from commercial skips   | Z,End
TV Editing  | NEXTCUT        | Jump to the next cut point            | 
PgDown

So, because CLEARMAP and LOADCOMMSKIP have "stolen" the keys used for 
jumping from cut to cut, we use a totally different key for doing so in 
the editor.  IMHO, we should be using the same keys to jump from cut 
point to cut point in playback and editing.  That means we need to find 
a new default key binding for CLEARMAP (I suggest just plain C) and 
LOADCOMMSKIP (I don't know what would be good for this one--perhaps P, 
which is used by TV Playback|Pause and TV Editing|PLAYBACK, but which 
most people think of as "Play," so you "play out the flag list"?  It's 
also already available on most users' remotes).

I'd also like to fix:

TV Editing  | BIGJUMPFWD     | Jump forward 10x the normal amount    | >,.
TV Playback | JUMPFFWD       | Jump ahead                            | 
PgDown
TV Playback | FFWDSTICKY     | Fast Forward (Sticky) or Forward
                                one frame while paused                | >,.

TV Editing  | BIGJUMPREW     | Jump back 10x the normal amount       | ,,<
TV Playback | JUMPRWND       | Jump back                             | PgUp
TV Playback | RWNDSTICKY     | Rewind (Sticky) or Rewind
                                one frame while paused                | ,,<

so we use the same "big jump" key in TV Editing as we do in TV Playback 
by default (and using PgUp/Down becomes possible once we fix the 
NEXTCUT/PREVCUT stuff).  Doing so would also mean that users who don't 
have FFWDSTICKY or RWNDSTICKY available on their remotes would still 
have access to BIGJUMPFWD/REW.  (I'm assuming people are more likely to 
have PgUp/PgDown on their remotes since they're used by the 
Global/PAGEUP and Global/PAGEDOWN bindings.)

Unfortunately, all of these key binding changes require DB updates that 
check the current mappings of the keys and only modify the mappings if 
they're the same as the defaults.  I'm thinking of making these changes 
after 0.24 release (which means that users will get new keys after 
learning the new editor UI, but we're quickly approaching release).  If 
others agree with the changes, I could get them done before 0.24, so 
users only have to re-learn the editor once.  If they're more 
controversial, I can hold off on them.

Other ideas appreciated, too.

Mike

*** A magnified view of the current position and one or both surrounding 
marks.