[mythtv] [mythtv-commits] Ticket #8127: [PATCH] Encode season & episode systematically on 2 char in programid

Michael T. Dean mtdean at thirdcontact.com
Tue Mar 9 02:55:10 UTC 2010


On 03/08/2010 09:21 PM, MythTV wrote:
> #8127: [PATCH] Encode season&  episode systematically on 2 char in programid
> -----------------------------------------------+----------------------------
>   Reporter:  Chris Browet                       |       Owner:  mdean
>       Type:  enhancement                        |      Status:  assigned
>   Priority:  minor                              |   Milestone:  unknown
> Component:  MythTV - Mythfilldatabase          |     Version:  unknown
>   Severity:  medium                             |     Mlocked:  0
> -----------------------------------------------+----------------------------
>
> Comment(by Chris Browet):
>
>   @Stuart:
>   Please take into account that the goal of the patch is to be able to get
>   Season/Episode information thru the API.
>
>   If I'm not mistaken, the info is already availabla in the
>   "recordedprogram" table "syndicate..." column (although I don't know what
>   this table is used for; seems very similar to "recorded").
>
>   The main problem is that there is no way to access this information thru
>   the api at the moment, only by sql. As the programid is sent, it is a
>   quick win to get Season/Episode info for xmltv users.
>
>   The proper way would be to return this info in a "QUERY RECORDING" (if I'm
>   not mistaken), but that is out of my league...
>
>    


(Not to speak for Stuart, but) I think the point that Stuart was making 
is that parsing information out of the programid is not the proper way 
of getting access to the season and episode information, as that 
information is only included at the end of the programid if the grabber 
provides season and episode information and only for XMLTV users (never 
for Schedules Direct users).  Therefore, if you write a program to rely 
on information that's sometimes encoded into the programid, you would 
need a way to determine if the information you're parsing actually means 
what you think it means.

Furthermore, the syndicatedepisodenumber is not what you want to use, 
either.  The syndicatedepisodenumber is a non-standard identifier used 
by the TV show's producers, and its format differs from show to 
show--which is why we don't provide it through the protocol.

If you have a need for season and episode number information, you'll 
need to modify the programinfo construct in MythTV to include a season 
and episode value (and modify the program table in the database to store 
it, and mythfilldatabase to populate it, and all associated code that 
needs changing for every programinfo change).  Or, you can wait until we 
get around to the planned changes that Stuart mentioned (at which point 
you'll likely find it's there for you).

I've usurped this ticket (and will be changing its summary (title) to 
reflect the bug that results from the issue with the current programid 
generation algorithm).  Thank you for the work you did to identify the 
problem--and for providing a patch.  However, because the change you 
proposed would break duplicate matching for a huge number of users as 
described in my previous comment (making users' years of MythTV usage 
history useless), we cannot make the change you proposed.

If you do decide to add season and episode information to the database 
and the programinfo, please open a new ticket for the patch.

Thanks,
Mike


More information about the mythtv-dev mailing list