[mythtv] [mythtv-commits] Ticket #9410: Positioning problems with BBC HD and BBC ONE HD recordings

[Taylor Ralph]

On Tue, Dec 28, 2010 at 12:55 PM, Paul Gardiner <lists at glidos.net> wrote:
> On 28/12/2010 00:59, Gavin Hurlbut wrote:
>>>
>>>  I've confirmed this is related to the h264 parser not detecting on_frame
>>>  properly while playing back or running commercial detection.
>>>
>>>  A temporary work around until this is fixed would be to return true
>>> always
>>>  for H264PreProcessPkt in avforatdecoder.cpp and rerunning commercial
>>>  flagging.
>>
>> This sounds like it's likely to mess up just as much as it fixes.
>> That area of the code has been rather problematic for us, and every
>> seemingly quick fix here tends to come back and bite us later on.  I
>> hope we get the real fix soon, whatever that may be. :)
>
> I'd be interested to give it a try, but I'm not sure I understand
> the suggested work around. H264PreProcessPkt looks to me like it
> recognises GOPs and pulls out info about changes in frame rate
> and size. Is the suggestion that this processing is unnecessary
> in streams that don't change size, and hence that you can skip
> it completely, or do you still have to walk some of the data?
>
> Cheers,
>        Paul.

No, just replace 'return on_frame' with 'return true' at the end of
the H264PreProcessPkt function.

Also, the dev who is the expert on the parser is aware of the issue
and will be looking at it when he gets a chance.

Regards.
--
Taylor