[mythtv] [mythtv-commits] mythtv commit: r25858 - intrunk/mythtv by cpinkham

[Mythtv]

-----Original Message-----
From: mythtv-dev-bounces at mythtv.org
[mailto:mythtv-dev-bounces at mythtv.org] On Behalf Of Mythtv
Sent: Thursday, 26 August 2010 9:47 PM
To: mythtv-dev at mythtv.org
Subject: Re: [mythtv] [mythtv-commits] mythtv commit: r25858 -
intrunk/mythtv by cpinkham

From: mythtv-commits-bounces at mythtv.org
[mailto:mythtv-commits-bounces at mythtv.org] On Behalf Of
mythtv at cvs.mythtv.org
Sent: Thursday, 26 August 2010 4:02 PM
To: mythtv-commits at mythtv.org
Subject: [mythtv-commits] mythtv commit: r25858 - in trunk/mythtv by
cpinkham

      Author: cpinkham
        Date: 2010-08-26 06:02:14 +0000 (Thu, 26 Aug 2010)
New Revision: 25858
   Changeset: http://svn.mythtv.org/trac/changeset/25858

Log:

Add the ability to playback remote DVD and Blu-ray directory images and
DVD
ISO files via MythTV's streaming protocol

--------------------------------------

Ok, I think I've got it working. Below is the change I made to support
dvd:mythtv:// filenames in ringbuffer:
------------------------------------------------------------------------
--------------------
--- libs/libmythtv/RingBuffer.cpp.orig  2010-08-26 18:59:09.601980187
+1000
+++ libs/libmythtv/RingBuffer.cpp       2010-08-27 11:12:42.453874960
+1000
@@ -332,7 +332,7 @@

         if (filename.left(6) == "dvd://")      // 'Play DVD' sends
"dvd:/" + dev
             filename.remove(0,5);              //             e.g.
"dvd://dev/sda"
-        else if (filename.left(5) == "dvd:/")  // Less correct URI
"dvd:" + path
+        else if (filename.left(4) == "dvd:")   // Less correct URI
"dvd:" + path
             filename.remove(0,4);              //             e.g.
"dvd:/videos/ET"

         if (QFile::exists(filename) || filename.startsWith("myth://"))
@@ -350,7 +350,7 @@

         if (filename.left(5) == "bd://")      // 'Play DVD' sends
"bd:/" + dev
             filename.remove(0,4);             //             e.g.
"bd://dev/sda"
-        else if (filename.left(4) == "bd:/")  // Less correct URI "bd:"
+ path
+        else if (filename.left(3) == "bd:")   // Less correct URI "bd:"
+ path
             filename.remove(0,3);             //             e.g.
"bd:/videos/ET"

         if (QFile::exists(filename) || filename.startsWith("myth://"))
------------------------------------------------------------------------
---------------------

I'm not sure if this is completely safe... was there a reason why it
only stripped the dvd: or bd: prefix when the filename started with /?

Cheers,
Richard.