[mythtv] [mythtv-commits] mythtv commit: r24250 by janne

[Janne Grunau]

On Mon, Apr 26, 2010 at 11:43:06AM -0400, Daniel Kristjansson wrote:
> On Sat, 2010-04-24 at 15:37 +0000, mythtv at cvs.mythtv.org wrote:
> > Author: janne
> >         Date: 2010-04-24 15:37:34 +0000 (Sat, 24 Apr 2010)
> > New Revision: 24250
> >    Changeset: http://svn.mythtv.org/trac/changeset/24250
> > 
> > Modified:
> > 
> >    trunk/mythtv/libs/libmythtv/playercontext.cpp
> > 
> > Log:
> > 
> > LiveTV: fix fast flipping between two channels using PREVCHAN
> > 
> > This is a regression introduced in 0.22. The current behaviour of
> > popping channels from the history when going back does make much sense
> > to me. Unless someone disagrees I'll change it to a history of the last
> > X channels sorted by last tuned.
> 
> Having a PopPreviousChannel() method push something onto the stack makes
> my head spin.

yes, it's a mess. Mostly caused by having the current channel on the
prevchan list. 

> Shouldn't the PREVCHAN keybinding just call GetPreviousChannel() ?

it's not that simple (see above) but fixing this properly is on my todo
list.

Janne