[mythtv] Quick Jack fix for 0.23

Jean-Yves Avenard jyavenard at gmail.com
Sat Apr 3 23:22:18 UTC 2010


Hi

On 4 April 2010 03:11, Ed W <lists at wildgooses.com> wrote:
> Grateful if someone could slip this in before the 0.23 release since it's
> otherwise a show stopper for myself and the other jack user...

That patch is wrong ...

        if (err = ERR_SUCCESS)

That will always resolve as TRUE if ERR_SUCCESS is non-null; so will
always call JACK_Close(audioid);
just like what the code does now...
If not, you never close the Jack port

I'm sure you intended to write err == ERR_SUCCESS
but I'm puzzled why your patch works for you


More information about the mythtv-dev mailing list