[mythtv] [mythtv-commits] Ticket #7313: mythfilldatabase doesn't notice errors downloading data

[f-myth-users at media.mit.edu]

    > Date: Mon, 12 Oct 2009 23:30:29 -0000
    > From: "MythTV" <mythtv at cvs.mythtv.org>

    >  If the data download fails partway through, mythfilldatabase doesn't
    >  notice, since it got some data, happily trashes your schedule. Notice the
    >  gzip failure.

Yes indeedy, as I noticed a while back when I had a period of
-extremely- poor connectivity for about a month.  I didn't bother
to bugreport it because I assumed newer versions of Myth caught
such errors.

FWIW, my approach (since I download the data using tv_grab_na_dd,
save it to enable retrospective debugging, massage it a bit, and
-then- hand it to mfdb (rather than letting mfdb handle things from
start to finish) was to make sure that the file contained the string
"</SOAP-ENV:Envelope>" before handing it to mfdb.  (I actually
separately flagged (a) nonexistent file, (b) empty file, and (c)
didn't contain the above string, but those were more to debug various
network issues than anything else---a single check for that string
would subsume the other two, of course.)

It seems to me that a similar check should be easy to incorporate
into mfdb itself, assuming that that's the correct (general) solution.
But it worked fine for me, since every file I've ever downloaded from
SD has that as its last line.