[mythtv] #5900 and AAC 5.1 audio

[Markus Schulz]

Am Sunday 31 May 2009 schrieb Jean-Yves Avenard:
> Hi
>
> 2009/6/1 Markus Schulz <msc at antzsystem.de>:
> > You're right if i completely disable internal volume control. In my
> > previously test i disabled only software mixing (set mixer device
> > from "software" to "ALSA:default"). After disabling the internal
> > volume
> >
> >
> > completely (like you suggest) it works as expected (2ch and 5.1ch
> > are fine and 2ch was upmixed to 5.1).
> >
> > Perhaps the mixer page should be disabled if we choose the "AC3
> > audio upmixer" on the first page.
>
> Well, if you do that, you loose all the benefit of the AC3 upmixer
> for people using analog audio...

what can you do with a dd5.1 ac3 stream over analog output?

> I found the problem
>
> is mythtv/libs/libmyth/audiooutputalsa.cpp , line #251 change:
>     if (isAC3upmix && !audio_passthru
>
> into:
>     if (isAC3upmix && !(audio_passthru || audio_enc)

thanks, i will try tomorrow.

> I'm going to make some more changes to the code itself. Foobum ,
> simplified the code by changing all the curstream->codec into ctx
>
> which breaks a few other interesting patches I've found.

hmm, simplify sounds good to me, perhaps better change the other 
patches?
What other patches do you mean?

msc