[mythtv] [mythtv-commits] Ticket #6376: Patch to save transcoded recordings

Chris Pinkham cpinkham at bc2va.org
Sun Mar 22 03:50:12 UTC 2009


* On Sat Mar 21, 2009 at 12:17:17PM -0500, Bill Cizek wrote:
>> Why not just change the transcoder to use the new filename for the new  
>> (transcoded) file and to copy the original metadata (at least that  

> Actually, Mike, your idea feels cleaner - keep the original file and  
> transcode into a new one - but I wanted to avoid screwing up anything  
> that assumes the filename doesn't change.  The basic transcode logic is  
> the same -- my patch just wraps around it to manage the .old file in a  
> different way. So far it works  well enough that I'm kickin' myself for  
> not having done this long ago.

I made a User Job perl script to do something similar about 3-4 years ago,
glad to see someone implementing a patch to do the same built-in.

http://www.gossamer-threads.com/lists/mythtv/users/152813?do=post_view_threaded#152813

I agree with Mike, can you have the transcoder write to the new
recorded.basename file.  In main.cpp, you can set outfile to the correct
new filename in main() and skip all the renaming stuff later.  You shouldn't
have to worry about the filenames.  You can let the original recorded entry
keep its filename and give your new entry the new filename.  You should also
to put in a check so the duplicate is created only if the user has both
SaveTranscoding and AutoExpireInsteadOfDelete turned on, otherwise they
aren't using the Deleted group at all and should just have the .old file
as they do now.

I think this will make the patch a bit simpler.

--
Chris


More information about the mythtv-dev mailing list