[mythtv] [mythtv-commits] Ticket #6376: Patch to save transcoded recordings

[Michael T. Dean]

On 03/19/2009 04:30 PM, MythTV wrote:
> #6376: Patch to save transcoded recordings
>
>  Currently if you transcode a recording and have the "Save original files
>  after transcoding" option checked, the original file is moved to a file
>  suffixed by .old:
>
>  (i.e. 1021_20090319110800.mpg -> 1021_20090319110800.mpg.old)
>
>  The attached patches change this functionality as follows:
>   * Create a new, valid filename (i.e. 1021_2009031911080'''1'''.mpg)
>   * Copy the recording info and markup data to reference the new filename
>   * Set this new recording to be "Deleted"
>   * Transcode the file
>   * Move the original file to the new name (i.e.
>  1021_20090319110800.mpg.old -> 1021_20090319110801.mpg)
>   

Why not just change the transcoder to use the new filename for the new 
(transcoded) file and to copy the original metadata (at least that which 
applies--so, ignoring recordedseek--which will be generated by the 
transcoder--and recordedmarkup) for the transcoded copy?  Nothing says 
that the copy we keep has to have the original filename.  And, though I 
haven't looked at all the code, I would expect that approach would 
simplify DuplicateForTranscoding() considerably.

Mike