[mythtv] [mythtv-commits] Ticket #6322: Enhanced cutpoint edit functionality

[René Bühlmann]

I applied this change and the faces now look the way they should :)
But I did not disable mmx. Configure says
MMX enabled               yes

But I did disable ssse3  (cause of some segfaults in libavcodec).

I like this feature, looks great :)
Thank you
René

Michael T. Dean schrieb:
> On 03/09/2009 03:16 PM, MythTV wrote:
>> #6322: Enhanced cutpoint edit functionality
>>
>>
>> Comment(by cizek):
>>
>>  Good to here.
>>
>>  On the Blue faces: Try making the following change in
>>  mythtv/libs/libmythtv/NuppelVideoPlayer.cpp, in the function
>>  "NuppelVideoPlayer::GetScreenGrabOfCurrentFrame()":
>>
>>  Change
>>  {{{
>>      edit_scaled_img =  tmpimage.scaled(size,
>>  Qt::KeepAspectRatio).rgbSwapped();
>>  }}}
>>
>>  to
>>
>>  {{{
>>      edit_scaled_img =  tmpimage.scaled(size, Qt::KeepAspectRatio);
>>  }}}
>>
>>  On my system the faces are blue if I ''don't'' use rgbSwapped(). If
>>  there's anyone who knows video and can shed some light on this I'd
>>  appreciate it.
>
> See the preview video code (which actually just displays a bunch of
> images--not a real video).  Currently, when Myth is compiled without
> MMX support, the faces are blue.  When compiled with MMX, the faces
> are correct.  If your code has the same bug as the preview code, it's
> "correct."  :)
>
> The main reason the blue-faces bug still exists in the preview video
> code is because it's a /great/ way to identify when a person or
> packager has improperly compiled MythTV (as on "normal" targets, MMX
> should /always/ be enabled or you will have issues).  So, there has
> been little motivation to fix it.  Unfortunately, it may have to be
> fixed sometime before long as people try to put mythfrontend in
> other-than-normal locations--such as ARM-based phones. 
> http://svn.mythtv.org/trac/ticket/5670
>
> Mike
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>