[mythtv] DVD playback Pause/Unpause problems

[stanley kamithi]

davin is right. go ahead and open a ticket. To answer your question, no one
got around to putting locks around code you mentioned and got it to work
right. So if you got it working, go ahead and submit your patches.

On Wed, Dec 9, 2009 at 11:57 PM, Davin McCall <davmac at davmac.org> wrote:

> Hi Jon
>
> I recommend just creating a ticket in trac (if there isn't one already) and
> attaching a patch to it. I've found that asking questions regarding how
> stuff works or is meant to work on this list doesn't necessarily get a
> response from the developers (not trying to issue blame, just stating fact),
> so it's best to forge on ahead and assume that if you see something that
> looks wrong, it probably is wrong. Also best to send the patch to this list
> with a note about what it's for / what it does and asking people to test it.
>
> Davin
>
>
>
> On 09/12/09 19:10, John Harvey wrote:
>
>> I am running into a problem with dvd playback where i can trigger
>> NuppelVideoPlayer::UnpauseVideo to loop forever, printing the message
>> "Waited too long to unpause video".
>>
>> The problem is caused by OutputVideoLoop calling PauseVideo(false) whilst
>> a
>> different thread is in the middle of doing an UnpauseVideo(true).
>>
>> For some reason the calls to PauseVideo&  UnpauseVideo in OutputVideoLoop
>> are not surrounded by locks on internalPauseLock. Is there a good reason
>> for
>> this?
>> Locking that from the OutputVideoLoop definitely seems to help but i
>> wanted
>> to try to understand why they aren't there before submitting a patch.
>>
>> I am also suspicious that calling PauseVideo(false) could break things for
>> the next call to UnpauseVideo if the video hasn't actually paused by the
>> time we call UnpauseVIdeo, though i have no proof of that yet. Is this
>> unfounded or is it worth investigating as well?
>>
>> Thanks
>>
>> Jon
>>
>> _______________________________________________
>> mythtv-dev mailing list
>> mythtv-dev at mythtv.org
>> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>>
>>
>
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mythtv.org/pipermail/mythtv-dev/attachments/20091211/9a00d3f2/attachment.htm>