[mythtv] [mythtv-commits] Ticket #7731: Delay file deletion in mythtranscode

[Jim Stichnoth]

On Wed, Dec 9, 2009 at 9:01 PM, Michael T. Dean <mtdean at thirdcontact.com> wrote:
> On 12/09/2009 11:39 PM, Jim Stichnoth wrote:
>>
>> On Wed, Dec 9, 2009 at 4:46 PM, Michael T. Dean wrote:
>>
>>>
>>> On 12/09/2009 07:25 PM, MythTV wrote:
>>>
>>>>
>>>> #7731: Delay file deletion in mythtranscode
>>>>
>>>>  Note that this patch does not change the preexisting odd behavior of
>>>>  resetting the recording's bookmark and watched flags when a cutlist is
>>>>  present.
>>>>
>>>
>>> The bookmark has to be reset after a transcode as the offset will be
>>> completely wrong when transcoding is complete (whether the cutlist was
>>> applied or not).
>>>
>>
>> From reading the code, if there is no cutlist, then the bookmark and
>> watched flags are left unchanged, as are the commflag and custlist
>> entries in the recordedmarkup table.
>
> Ah, yeah, it's a mark on frame number, not an offset.  Too many programs
> that specify it different ways, so I misremembered--I should have looked
> before adding that parenthetical.
>
> But if you do apply a cutlist, it can change, so translating it becomes a
> feature request without a patch rather than not doing so being an "odd
> behavior".  :)

OK, as penance for poor choice of language, I will go ahead and make a
patch.  :)

Jim