[mythtv] [mythtv-commits] Ticket #7731: Delay file deletion in mythtranscode

[Michael T. Dean]

On 12/09/2009 07:25 PM, MythTV wrote:
> #7731: Delay file deletion in mythtranscode
>
>  Note that this patch does not change the preexisting odd behavior of
>  resetting the recording's bookmark and watched flags when a cutlist is
>  present.

The bookmark has to be reset after a transcode as the offset will be 
completely wrong when transcoding is complete (whether the cutlist was 
applied or not).

Resetting the watched flag is a judgment call, but I think the flag is 
reset because otherwise, the recording is high-priority for auto-expiry 
and if the user just went to the trouble of transcoding the recording, 
she probably wants it to stick around at least for a little while.  And, 
if the user enables:

Automatically mark a recording as watched
If set, when you exit near the end of a recording it will be marked as 
watched. The automatic detection is not foolproof, so do not enable this 
setting if you don't want an unwatched recording marked as watched.

and then enters the recording, edits it, creates a cutlist, and exits 
from near the end, the show is automatically marked as watched even 
though the user didn't watch anything.***  So, in that case, it makes 
sense to reset it, anyway.

Ever since the watched flag was added to MythTV, mythtranscode's 
handling of it has been the same ( 
http://svn.mythtv.org/trac/changeset/11138 ).  Also, Stuart M. mentioned 
that this is the behavior of the initial patch over 2 years ago at 
http://www.gossamer-threads.com/lists/mythtv/dev/222276#222276 .

Someone else (Chris Pinkham? or possibly Stuart Morgan) is likely to 
know for sure why the decision was made.  If someone gives an official 
position on it, we can easily close 
http://svn.mythtv.org/trac/ticket/7718 (with a simple patch or as invalid).

Mike

*** Before people start saying that it doesn't because they used to do 
that all the time in 0.21-fixes, "Automatically mark a recording as 
watched," now actually works in 0.22 and above.  It did not work 
properly in some circumstances if prompts were enabled, so you may never 
have seen the proper behavior on older versions.  So for "Automatically 
mark..." users who edit cutlists but don't transcode, they'll need to 
either exit from some point > 12min from the end of the recording or 
reset the watched flag through the menu after exiting if they want it unset.