[mythtv] [mythtv-commits] Ticket #5140: QFile::open() of device should be checked for failure in MpegRecorder::StartRecording

[Erik Hovland]

On Tue, May 06, 2008 at 09:54:32AM -0400, Daniel Kristjansson wrote:
> On Tue, 2008-05-06 at 09:08 +0200, Petr Stehlik wrote:
> > MythTV wrote:
> > > Changes (by danielk):
> > >  (In [17269]) Fixes #5140. Check for failure to reopen ivtv device after
> > >  error.
> > 
> > May I ask if these Erik's patches will go into 0.21-fixes as well 
> > eventually? I can imagine that they could fix a number of weird errors 
> > some users are experiencing.
> 
> Unless there is a particular request for a patch to be backported
> or it looks like it will solve a reported problem or serious problem,
> it will not be backported. This fix for instance, will most likely
> just log the error, and that will make it easier for us to determine
> (when we get logs in an error report) that the problem is with setup
> or the driver and not in MythTV. There is a chance that it will help
> us recover from an intermittent driver problem, but I wouldn't bet
> anything on it.

I agree with Daniel. Almost all of the patches I have submitted get rid
of the little issues that can cloud real bugs. They rarely provide a
fix to a serious reported bug. Their application to the 0.21
branch should be applied only after some more thought.

Having said that, lets hope we get trunk up to 0.22 release as fast as
possible. I would like to see 0.22 come out this year.

E

-- 
Erik Hovland
mail: erik at hovland.org
web: http://hovland.org/
PGP/GPG public key available on request