[mythtv] [mythtv-commits] mythtv commit: r16256 by nigel
Michael T. Dean
mtdean at thirdcontact.com
Fri Mar 7 19:56:28 UTC 2008
On 02/27/2008 12:26 AM, Michael T. Dean wrote:
> On 02/26/2008 11:51 PM, Nigel Pearson wrote:
>
>>> willing to do a patch with the comment that also fixes them,
>>> if necessary.
>> Why not. Should be just
>> display.contains("<br", true)
> Now I'm starting to wonder if I knew something when coding that that
> I've since forgotten as I put an explicit false in there for case
> sensitivity when the default is true... I really can't think of a
> reason why I would have done that, but I also have to believe that since
> I did it I must have had a reason at the time.
>
> Because of that, I'd like to play around with it and do some testing. I
> won't be able to do that until the weekend, but I'll test it and submit
> a patch to change it if I can't find a reason to leave it as is, or a
> patch with the "<br" comment and a comment about case sensitivity if
> there is a reason to leave it as is.
Heh. It turns out that the code is already doing a case-insensitive
match. I completely misread the QT docs/suffered a logic failure. The
second argument to the QString::contains() function is cs=TRUE (where cs
means "case sensitive"). The false I'm passing disables case-sensitive
matching, so it becomes case-insensitive matching.
Sorry for the noise. I really shouldn't make comments about code--even
if I'm the author of the code (and, in theory, understood it at one
time)--when just glancing over the code while on the road. Thanks for
helping me get there (eventually), Nigel.
I'm going to hold off on making a ticket solely for the comment about
how "<br" allows matching either "<br>" or "<br />". If you'd like to
commit it in one of your changes, that would be great. If not, I may
make some more changes in that area eventually and just sneak the
comment into another patch. I did attach a patch (which may be more
work than just changing the file), just in case. :)
Thanks,
Mike
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mythtv-misc_status_line_break_matching_comment.patch
Url: http://mythtv.org/pipermail/mythtv-dev/attachments/20080307/615fc35c/attachment.diff
More information about the mythtv-dev
mailing list