[mythtv] [mythtv-commits] Ticket #5615: Add keyboard input to MythConfirmationDialog, exec() to new mythui Dialogs

[Paul Harrison]

Stuart Morgan wrote:
> On Tuesday 12 August 2008 13:23:49 MythTV wrote:
>   
>> #5615: Add keyboard input to MythConfirmationDialog, exec() to new mythui
>> Dialogs
>> -------------------------+-------------------------------------------------
>> - Reporter:  nigel        |       Owner:  ijr
>>      Type:  enhancement  |      Status:  new
>>  Priority:  minor        |   Milestone:  0.22
>> Component:  mythtv       |     Version:  head
>>  Severity:  medium       |     Mlocked:  0
>> -------------------------+-------------------------------------------------
>> - 1. MythConfirmationDialog currently only responds to mouse clicks
>>     
>
> That first one should not be true, although I've not actually tested it, there 
> is no obvious reason that it doesn't work. The fix used isn't correct since 
> widgets handle their own keypress and ESCAPE etc should be handle by 
> keypressevent from the base class.
>
>   
It works OK for me using the keyboard. I'm wondering if the problem is 
the  contrast between when a button has focus and hasn't. I find it very 
hard to tell where the focus is or if it has moved at all. 
>> 2. 
>> libmythui dialogs are modal, but don't provide an API which allows the
>> calling code to block until the user selects something off them
>>  Attached patch fixes both of these. Have done reasonable testing, but not
>>  with any animation-heavy themes (only clock widget) or other background
>>  heavy processing stuff.
>>     
>
> Paul has another idea which he might like to share here.
>
>   
I've attached what I have to the ticket.

> I've developed an aversion to blocking dialogs. When I originally started 
> converting to mythui I missed them but Isaac very deliberately designed them 
> to be non-blocking and I've grown used to it now.
>   

Making them blocking makes life a lot easier. The way they work now if 
you don't pay attention it is very easy for things to happen in the 
wrong order as I found out while converting some the MythGallery popups.

Paul H.