[mythtv] [mythtv-commits] Ticket #3823: flags commercials on channels set not to include commercials

[Nick Morrott]

On 24/04/2008, Kevin Kuphal <kkuphal at gmail.com> wrote:
>
>
> On Thu, Apr 24, 2008 at 12:27 PM, MythTV <mythtv at cvs.mythtv.org> wrote:
>
> >
> > #3823: flags commercials on channels set not to include commercials
> >
> ---------------------------------------------------------------+------------
> >
> >  Reporter:  Pekka Jääskeläinen <pekka.jaaskelainen at gmail.com>  |
> Owner:  cpinkham
> >     Type:  defect                                             |
> Status:  closed
> >
> >  Priority:  minor                                              |
> Milestone:  unknown
> > Component:  mythtv                                             |
> Version:  head
> >  Severity:  medium                                             |
> Resolution:  worksforme
> >  Mlocked:  0                                                  |
> >
> ---------------------------------------------------------------+------------
> >
> > Comment(by sphery <mtdean at thirdcontact.com>):
> >
> >  The issue is due to improper configuration of the channels.  The reporter
> >  most likely used MythWeb's channel editor to set the commfree field.
> >  Since commfree is deprecated by commmethod, this does absolutely nothing.
> >  Since MythWeb has not yet been updated to use commmethod, the proper fix
> >  is to use mythtv-setup to set the commercial detection method to
> >  "Commercial Free" for each channel, as required.
>
>
> Not having looked closely at this but thinking off the top of my head, is
> the commfree boolean a column?  Should we simply drop that column from the
> database so that this behavior generates a more obvious error rather than
> silently setting an unused variable?  Other 3rd party programs may have the
> same issue and leaving the unused column just makes it seem like it is still
> supported.

See http://svn.mythtv.org/trac/ticket/5195 - this issue was reported
by Janne a couple of weeks ago. Per
http://svn.mythtv.org/trac/changeset/12957/trunk/mythtv/libs/libmythtv/dbcheck.cpp
the field is due to be dropped in 0.22.

-- 
Nick Morrott

MythTV Official wiki:
http://mythtv.org/wiki/
MythTV users list archive:
http://www.gossamer-threads.com/lists/mythtv/users

"An investment in knowledge always pays the best interest." - Benjamin Franklin