[mythtv] [mythtv-commits] Ticket #4132: In some menu's ESCAPE action is not handled appropriately

Bruce McKenzie brucem at dynamicrange.com
Tue Nov 20 19:13:40 UTC 2007


On Tue, 2007-11-20 at 10:26 +0000, Matthew Wire wrote:
> Following commit 14908 I've been updated some patches for the new dialog
> code.  This made me notice some inconsistency in the method names.
> 
> addWidget
> addLayout
> addLabel
> addButton
> ShowPopup
> ShowPopupAtXY
> ExecPopup
> ExecPopupAtXY
> showOkPopup
> showOkCancelPopup
> Show2ButtonPopup
> ShowButtonPopup
> showGetTextPopup
> showPasswordPopup
> AcceptItem
> accept
> reject
> popupDone
> ~MythPopupBox
> focusNextPrevChild
> keyPressEvent
> defaultButtonPressedHandler
> 
> Most of the methods use a small letter at the start but some use a
> capital: ShowPopup, ShowPopupAtXY, ExecPopup, ExecPopupAtXY,
> Show2ButtonPopup, ShowButtonPopup.
> Normally, it would cause too much breakage to change these, however
> since 14908 already breaks third-party plugins etc. I think it would be
> worth changing all these to lower case for consistency.
> 
> Paul/Daniel - What do you think?
> I will do the work required, I just need to know it's worth doing first
> so I don't waste my time.

That's funny.

I have a patch about ready to submit that makes various UI labels
consistent:

OK vs. Ok
Re-record ReRecord rerecord re-record
PlayList Playlist playlist

It's a lot of changes when you include all the themes and plugins, but
so far it looks good.

Cheers,

B.

-- 
Bruce J. McKenzie -- brucem at dynamicrange.com
Fullerton, CA



More information about the mythtv-dev mailing list