[mythtv] [mythtv-commits] Ticket #1104: multi channel audio support

[Janne Grunau]

On Wednesday 27 June 2007 04:37:35 Mark Spieth wrote:

sorry for answering late, I marked the mail as todo and forgot about it 
then.

> can you make the function ac3_sync in libavcodec/parser.c not static
> please if its not too much trouble.

No. Just do it yourself in the patch. I'll try to remember it and not to 
break with the next ffmpeg merge (ac3_sync will move to ac3_parser.c).

> It makes removing liba52 easier for the multichannel audio patch.
> Currently there is a call to a52_syncinfo which will be replaced by a
> call to ac3_sync.

Sure, I've done the same for AC3 passthrough after the last ffmpeg 
merge.

> If you agree, Ill upload a patch for another non a52 version on the
> weekend. Otherwise Ill just copy code from parser.c as a workaround

no, just make the function nonstatic.

> as I did with dts. see audiooutputbase.cpp in the patch if you are
> interested.

One question regarding dts-passthrough: Is libdts only needed as codec 
in libavcodec? If yes, we can get rid of it with the next merge. 
libavcodec has a native DCA/DTS decoder.

Janne