[mythtv] [mythtv-commits] Ticket #3788: instead of deleting a show, mark it for auto-expire and put in a "deleted" group

[Chris Pinkham]

* On Fri Aug 03, 2007 at 02:03:11AM -0000, MythTV wrote:
> #3788: instead of deleting a show, mark it for auto-expire and put in a "deleted"
> group

You should use a number higher than 1, but lower than kLiveTVAutoExpire
(10000) for the autoexpire value when you put a program in the Deleted
recgroup.  This will force the program to be expired after LiveTV
programs, but before regular programs when programs are deleted to free
up disk space.  I'd suggest creating a kDeletedAutoExpire in tv.h with
a value of 9999 or somewhere around there.  You could convert the
kLiveTVAutoExpire const to an enum also probably.  My thinking is that
if you explicitly say to delete a program, you want it to expire before
other unwatched programs that may auto-expire because of disk space issues.

When you undelete, you should reset the autoexpire value on the
recording to whatever the default for that recording was (based on
recordid), but I wonder if you should just force autoeexpire to 0 in
this case.  If I'm undeleting something, I probably don't want it to
be auto-expired.  That may be too much assumption though.

I'm not sure of your playbackbox.cpp logic where you decide whether to
display these recordings in 'All Programs'.  Do you want to display
Deleted recordings in All Programs just because LiveTVInAllPrograms is
turned on?  It would seem like you would never want to see these
deleted recordings in All Programs, you would only want to see them if
the user viewed the Deleted recgroup.

You may want to change the 'Delete' menu button to say something
different when you're displaying the Deleted recgroup.  With your
current change, you'll end up with a "Undelete" button a few spaces
above the "Delete" button.  When the recgroup is 'Deleted', the
'Delete' button could be called 'Delete Now' or something to show
that it will actually force a delete rather than letting the program
auto-expire.  Putthing these two buttons beside each other also seems
to make sense rather than having the 3-4 other buttons inbetween
them.

--
Chris