[mythtv] [mythtv-commits] Ticket #3302: Do not update mfdb min/max hour for MythFillGrabberSuggestsTime

[Chris Pinkham]

* On Fri Apr 13, 2007 at 02:00:13PM -0000, MythTV wrote:
> #3302: Do not update mfdb min/max hour for MythFillGrabberSuggestsTime
> ----------------------------------------------+-----------------------------
>  Reporter:  sphery <mtdean at thirdcontact.com>  |        Owner:  stuartm
>      Type:  patch                             |       Status:  new    
>  Priority:  minor                             |    Milestone:  unknown
> Component:  mythfilldatabase                  |      Version:  head   
>  Severity:  medium                            |   Resolution:         
> ----------------------------------------------+-----------------------------
> 
> Comment(by sphery <mtdean at thirdcontact.com>):
> 
>  The more I think about it, the less I like the idea of the user being able
>  to "break" mythfilldatabase by specifying improper mfdb min/max hour with
>  MythFillGrabberSuggestsTime.  mythtv-DataDirect-
>  no_update_min_max_hour-20070413.patch changes the approach so the dbcheck
>  is no longer needed and instead simply sets and resets the value of
>  MythFillMinHour every day.  If used, only mythtv-DataDirect-
>  no_update_min_max_hour-20070413.patch should be applied.

I was going to comment on this when I saw the thread and ticket opened, but
now don't have to as much. :)  I agree that we should be resetting
MythFillMinHour every day to make sure that our suggested time will be
honored.  It would be nice if we could get the min/max settings greyed out
in the settings page if MythFillGrabberSuggestsTime is turned on, but that's
not required to fix this bug.

--
Chris