[mythtv] 'Never Record' button and Subtitle then Desc method

[Martin Long]

No... this one threw me at first, but look closely - kDupCheckSubDesc will
actually satisfy 2 of the conditions. It satisfies BOTH these conditions: 

	(dupmethod & kDupCheckSub) && subtitle != "" 
      (dupmethod & kDupCheckDesc) && description != ""

Note the bitwise & -  kDupCheckSub is 2, kDupCheckDesc is 4 so
kDupCheckSubDesc, being 6 actually satisfies BOTH of the bitwise AND
conditions. Clever trick that!

So, yeah, the change you suggested should work. I've provided a patch anyway
- tested and working.

I'll go and attach it to the ticket now. 

Thanks for pointing it out!

:) 

Martin


-----Original Message-----
From: mythtv-dev-bounces at mythtv.org [mailto:mythtv-dev-bounces at mythtv.org]
On Behalf Of Stuart Morgan
Sent: 03 April 2007 14:03
To: mythtv-dev at mythtv.org
Subject: [mythtv] 'Never Record' button and Subtitle then Desc method

The 'Never Record' button isn't displayed for upcoming recordings which use 
the kDupCheckSubThenDesc method. Now I can easily add the following which I 
reckon would fix the problem, but I must be missing something.

((dupmethod & kDupCheckSubThenDesc) && (subtitle != "" || 
description != "")) ||

With the kDupCheckSubDesc method the button is shown even though it seems it

should fail all the tests. (The programid is empty and the category_type is 
empty).

-- 
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev at mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: duplicate.patch
Type: application/octet-stream
Size: 739 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20070403/1f378144/attachment.obj