[mythtv] [mythtv-commits] Ticket #2556: Bogus video streams in output PMT

[Stuart Auchterlonie]

On Tue, Oct 10, 2006 at 02:39:08PM +1000, Andrew Dennison wrote:
> On 10/10/06, Daniel Kristjansson <danielk at cuymedia.net> wrote:
> > On Mon, 2006-10-09 at 14:21 +0000, MythTV wrote:
> > > #2556: Bogus video streams in output PMT
> > >  The invalid streams (0x4ae & 0x40d) are only found
> > >  in the output PMT, not in the recording itself.
> >
> > Perhaps something in the DVBRadio & MHEG dummy video support?
> 
> Sounds very similar an issue I noticed, below is an extract from the
> comments I added to ticket #1341
> 
>  In [9314] STREAM_TYPE_PRIVATE_DATA was added to is_desired_stream(), and
>  these streams are handled in the default: of init_stream(). However this
>  means that unknown private streams are tagged as
>  {{{
>  codec_type = CODEC_TYPE_VIDEO;
>  codec_id = CODEC_ID_MPEG1VIDEO;
>  }}}
>  This causes problems with MPEG2FIX as the stream is definately not
>  MPEG1VIDEO (see #2007).

Digging into this a bit more, from [10458] we added

{{{
if ((dvbci.component_tag >= 0) && (stream_type == STREAM_TYPE_PRIVATE_DATA))
{
    /* Audio and video are sometimes encoded in private streams labelled with a component tag. */
    if (dvbci.language[0])
        stream_type = STREAM_TYPE_AUDIO_MPEG2;
    else
        stream_type = STREAM_TYPE_VIDEO_MPEG2;
}
}}}

This will effectivly classify any data stream as a Video stream
if it is in a private data stream and is not an audio stream.