[mythtv] [mythtv-commits] Ticket #2726: someone broke the HDTV tuner between 11810-11820

[Daniel Kristjansson]

On Sun, 2006-11-26 at 01:08 +0100, Janne Grunau wrote:
> On Sunday 26 November 2006 00:11, MythTV wrote:
> > #2726: someone broke the HDTV tuner between 11810-11820
> >------- Comment (by danielk):
> >
> >  Janne, it's DB update 1168 that breaks ATSC. Your DB update sets all
> > the ATSC multiplexes imported channels.conf information (before I
> > fixed channels.conf import a couple weeks ago) to 'mpeg'.
> 
> Before it was "dvb"? Yeah, that's bad, sorry. I thought you would take 
> care of the atsc related changes. My patch was only intended as fix for 
> the DVB networkid 0 issue.
> 
> > But this 
> > breaks tuning for anyone who later scanned for channels, because the
> > MPEG program number is set to -1 when ATSC tuning information is
> > available.
> 
> The channel sets it to -1? 

No the mpeg program number. It's basically there to make bugs like
this cause tuning to break immediately so that we don't get harder
to debug problems festering in the code for a long time.

> The main part of the problem is that the scanner adds the atsc tuning 
> information and doesn't update the sistandard of the multiplex 
> to 'atsc'. It is working fine for DVB channels. I tested it before I 
> submitted the dbcheck patch.

The sistandard for ATSC streams should never be set to "dvb" in the
first place. This is why I didn't catch the problem when I reviewed
your patch. Your patch should have worked fine. I forgot that the
channels.conf import had been broken for a long time so many people
would have really broken dtv_multiplex tables.

-- Daniel