[mythtv] [mythtv-commits] mythtv commit: r11776 - in trunk by skamithi (DVD bookmarks)

[stanley kamithi]

dvd in a dvd drive is treated like an iso copy.

check out dvd_read_name() in vm.c in the libmythdvdnav stuff.
it reads the serial number and title from the dvd structure.
it only works with iso images or dvds in a dvd player.
needs to be modified to read the dvd stucture when you use VIDEO_TS
directories.

the serial number and title are used by the dvd bookmarking code.
if the serial number is not present, a bookmark is not created.



On 11/18/06, David Asher <david.asher at caviumnetworks.com> wrote:
>
> If I may ask, what is the bug in libdvdnav?  I'd be interested in
> finding a fix -- I prefer using VIDEO_TS instead of the iso copies of
> DVDs.
>
> What is a DVD in a DVD-ROM drive considered?  I would assume VIDEO_TS.
>
> David.
>
> mythtv at cvs.mythtv.org wrote:
> >       Author: skamithi
> >         Date: 2006-11-18 18:23:07 +0000 (Sat, 18 Nov 2006)
> > New Revision: 11776
> >    Changeset: http://cvs.mythtv.org/trac/changeset/11776
> >
> > Modified:
> >
> >    trunk/mythplugins/mythdvd/mythdvd/settings.cpp
> >    trunk/mythtv/libs/libmythtv/DVDRingBuffer.cpp
> >    trunk/mythtv/libs/libmythtv/DVDRingBuffer.h
> >    trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp
> >    trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.h
> >    trunk/mythtv/libs/libmythtv/avformatdecoder.cpp
> >    trunk/mythtv/libs/libmythtv/dbcheck.cpp
> >    trunk/mythtv/libs/libmythtv/programinfo.cpp
> >    trunk/mythtv/libs/libmythtv/programinfo.h
> >    trunk/mythtv/libs/libmythtv/tv_play.cpp
> >    trunk/mythtv/programs/mythfrontend/main.cpp
> >
> > Log:
> >
> > Refs #1544. DVD bookmark support. doesn't work if dvd is in a VIDEO_TS
> > directory, due to a bug in dvd_read_name() in libdvdnav. i am not
> interested
> > in fixing this because all my dvds are in the iso format. support is
> > disabled by default (for now). go to the DVD Settings to turn it on.
> > used for about 9 months now, works for most dvds, i've watched.
> >
> >
> >
> >
> > _______________________________________________
> > mythtv-commits mailing list
> > mythtv-commits at mythtv.org
> > http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits
> >
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mythtv.org/pipermail/mythtv-dev/attachments/20061118/61193554/attachment.htm