[mythtv] [mythtv-commits] Ticket #1945: DVB-S/diseqc patch

Daniel Kristjansson danielk at cuymedia.net
Wed Jun 28 03:45:57 UTC 2006


On Wed, 2006-06-28 at 00:28 +0000, MythTV wrote:
> #1945: DVB-S/diseqc patch
>  I'll give it a test when I can, but I did notice a few things just going
>  over the changeset, I think at the very least the last two will have to be
>  corrected in one way or another before the stuff will work properly:
<snip>
Just make patches for each one. I'm strapped for time, but small patches
I can often review while a compile is going or something like that.

>  * The changes to libmyth/settings.cpp+h are needed for the device tree
>  editor to work properly. The change allows the myth listbox to have
>  multiple strings with the same displayed value, which is needed for the
>  GUI since the tree display is actually just an indented listbox -- and
>  tree nodes can easily have the same name.
I believe you duplicated a method that already exists under another name
in a parent class. I forget the name at the moment but it shouldn't be
hard to find, it is also a slot accepting an int...

>  On an unrelated note, if it's easy to take the new rotor position status
>  signal monitor value and stick it in the OSD, that would be a really nice
>  addition to this patch. I have a pretty rough understanding of the signal
>  monitor code, so I didn't want to do much more to that stuff than was
>  necessary in the patch.
This is easy, just look at UpdateOSDSignal(), the position should already
be available there under the short name. (i.e. "snr", "seen_pat",
"matching_pat", etc.). I believe you made the short name "pos".

-- Daniel




More information about the mythtv-dev mailing list