[mythtv] [mythtv-commits] Ticket #1900: Catch error condition in osd.cpp

[Stuart Morgan]

On Wednesday 07 June 2006 00:07, MythTV wrote:
> #1900: Catch error condition in osd.cpp
> *snip*
>  Patch is malformed + I don't see the need for it...

I've attached a fixed version of the patch. The reason for it is simple, in 
adding an extra item to that menu for a forthcoming patch it caused errors 
futher down the line. After tracking down the cause it occurred to me that it 
would be courteous to provide an informative message at the point where the 
actual error exists, for other code contributors and theme authors. If the 
number of options changes in that menu in future releases then it will break 
a number of unofficial themes with no clear explaination to end user.

The ideal solution would be to re-write that whole thing so it doesn't rely on 
a hardcoded number of option containers in the theme. I've no immediate plans 
to do that, so a meaningful error is better than nothing for now.
-- 
Stuart Morgan