[mythtv] [mythtv-commits] Ticket #1147: permissions problem -> coredump
Dag Nygren
dag at newtech.fi
Tue Jan 31 21:27:51 UTC 2006
> On Tuesday 31 January 2006 15:52, Dag Nygren wrote:
> > Sure, but we are talking networking here. You can never assume
> > that a network connection stays up and running 100%, never.
>
> Where's that assumption made?
If you are not checking if you have a connection after initializing
it you do assume that everything is OK.
And why would you check for this condition in other subs then?
> > Not all of them by far.
> > I fixed one of my admittingly smallish problems by adding a check,
> > but that was not accepted as a patch as this was a problem only for
> > me and one other guy... (in TVRec::DoGetNextChannel() )
>
> Looks like every single database hit in TVRec::DoGetNextChannel() checks for
> the successful operation of the queries to me. Testing the databse
> connection separately gains absolutely nothing.
>
> Your patch was rejected because it didn't do anything, and was obviously not
> correct.
Well. worksforme ;-)
> > Really?
> > MSqlQuery::exec() is not trying to reconnect but just pass the query on to
> > QSqlQuery::exec() and then logs it. Can't see prepare( kicking the database
> > either.
>
> QSqlQuery does it internally. 'KickDatabase' is just an extra test, since
> QSqlQuery doesn't always retry the query on a reconnect properly.
Where is that documented? Cannot find it in the API for Qt.
If that is the fact, I apologize very much for bringing up this example.
Dag.
More information about the mythtv-dev
mailing list