[mythtv] [mythtv-commits] Ticket #1139: Add HD, CC, and Stereo indicators

[Kevin Kuphal]

Chris Pinkham wrote:
>> #1139: Add HD, CC, and Stereo indicators
>> ---------------------+------------------------------------------------------
>>  Reporter:  kkuphal  |        Owner:  kkuphal
>>      Type:  patch    |       Status:  new    
>>  Priority:  minor    |    Milestone:  0.20   
>> Component:  mythtv   |      Version:  head   
>>  Severity:  medium   |   Resolution:         
>> ---------------------+------------------------------------------------------
>> Comment (by gdragon at jetcom dt org):
>>
>>  Wouldn't it be better to squish these into a bit mask? It seems silly to
>>  me to add more bytes to an already large program info, that gets
>>  frequently transmitted over the network.
>>
>>  Or maybe it's the embedded programmer in me. :/
>>     
>
> These could probably be rolled into the FlagMask bitmask defined in
> programinfo.h and used in playbackbox.cpp and a few other places.
>
>   
Yes, I see that would work better and also probably not require a 
protocol bump as we'd be accessing additional flags of the same bit 
rather than adding additional pieces to the structure.  I'll see if I 
can whip up a quick change for that.  If someone can confirm using flags 
won't affect the protocol, I'll commit it when I'm done testing.

Kevin