[mythtv] Ticket #1152: Commflag, etc., for OSX bundled apps + cleanups

[David Abrahams]

MythTV <mythtv at cvs.mythtv.org> writes:

> #1152: Commflag, etc., for OSX bundled apps + cleanups
> ---------------------------------------+------------------------------------
>  Reporter:  dave at boost-consulting.com  |        Owner:  nigel   
>      Type:  patch                      |       Status:  assigned
>  Priority:  minor                      |    Milestone:  0.20    
> Component:  mythtv                     |      Version:  head    
>  Severity:  medium                     |   Resolution:          
> ---------------------------------------+------------------------------------
> Changes (by nigel):
>
>   * status:  new => assigned
>
> Comment:
>
>  About half of the patches in osx-packager have been applied. I am not
>  comfortable with the MythContext changes yet - a lot of testing will be
>  required.

I should explain the MythContext changes.  They probably look more
radical than they are because of the elimination of GetInstallPrefix.

The problem was one of identifying the right abstractions.  The
install prefix was not an abstraction of anything that mapped into the
OSX world.  There were two fundamental abstractions as far as I could
tell:

   1. Find an application in the myth suite, which became
      GetAppPath(name).

   2. Find the directory that contains the myth share/ and lib/
      subdirectories, which was only needed internally to MythContext.
      All clients of MythContext were able to use higher-level
      functions such as GetThemesParentDir (some were needlessly using
      GetInstallPrefix and then appending a path that was available
      through other members of MythContext).  Therefore I removed
      GetInstallPrefix from the interface.

I tried to arrange the changes so that when Myth was being used as a
raw application (not as part of a package) it would behave the same
way as it always has, and so that a mixture of packages and raw
applications would be possible.

HTH,

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com