[mythtv] [mythtv-commits] mythtv commit: r10773 by danielk

[Daniel Kristjansson]

On Tue, 2006-08-22 at 14:33 +0100, Stuart Morgan wrote:
> On Tuesday 15 August 2006 16:49, mythtv at cvs.mythtv.org wrote:
> > Fixes #2177. Hides channels hidden in EPG when channel flipping.
> >
> > I'm not sure if this really is better. I read the arguements from last year
> > and restored the behaviour that was implemented then. However, if you don't
> > like it there is a boolean "skip_non_visible" in channelutil.cpp, if you
> > flip that these channels will only be hidden in the EPG and not in channel
> > flipping.
> 
> I note the old code to hide visible channels is still there and would still 
> work, any reason why you chose your solution over just using the existing 
> flag to getChannels? At least for 0.20 this should work as intended, or not? 
> The "skip_non_visible" bool could still be used, it would just need to be 
> moved up to the old code.

You mean ChannelUtil::GetChannels() ? Using that to populate the list of
channels
on the source would make the invisible channels untunable, we just want
them to be "invisible".

The skip_non_visible just toggles whether the channels are visible in
the
channel flipping routines. When it is set to false we get the documented
behaviour, when we set it to true we get the 0.19 behaviour. Right now
it
is set to true. The channels are still tuneable via direct entry as in
0.19 and as needed by the scheduler.

-- Daniel