[mythtv] [mythtv-commits] Ticket #2210: DVB subtitles are not enabled after exiting from the teletext view
Stuart Morgan
stuart at tase.co.uk
Mon Aug 21 21:20:42 UTC 2006
The various different types is pretty confusing to say the least. The
particular problem with the ticket and patch in question is whether they are
*all* handled in the same manner. From what I was able to make out they are
handled on a per frame basis - we look at textDisplayMode for each frame and
display the different subtitle/caption type accordingly.
If that is the case then changing textDisplayMode is enough to
enable/switch/disable all forms of subtitle/caption. That is all the patch
does.
Having had a second look, the exception to this is teletext captions (or
whatever you call them) which aren't enabled on a per frame basis. The patch
is unlikely to prevent them from working in anyway, but they won't be
switched back on after exiting a teletext menu i.e. no different to the
unpatched version.
To prevent any potential weirdness if enableTeletext is called twice without
disableTeletext having been called we can wrap the assigning of
prevTextDisplayMode with if (textDisplayMode & MASK) { ... }
--
Stuart Morgan
More information about the mythtv-dev
mailing list