[mythtv] Patch proposal for better logging of ivtv select timeouts
f-myth-users at media.mit.edu
f-myth-users at media.mit.edu
Sat Apr 15 06:48:03 UTC 2006
> Date: Thu, 13 Apr 2006 10:52:33 -0400
> From: Daniel Kristjansson <danielk at cuymedia.net>
> On Wed, 2006-04-12 at 21:34 -0400, f-myth-users at media.mit.edu wrote:
> > I'd like to propose changing this line in libs/libmythtv/mpegrecorder.cpp:
> >
> > printf("select timeout - ivtv driver has stopped responding\n");
> >
> > to something like
> >
> > printf("%s select timeout - ivtv driver has stopped responding\n", videodevice.ascii());
> >
> > If I opened a ticket and generated a patch for this, would it be
> > likely to be accepted?
> Nope, but if you change the cerr redirects and printfs to the proper
> verbose macros that would be appreciated and accepted. Assign the ticket
> to 'danielk' for the quickest response.
Err, okay. :) I was assuming that the less invasive the patch, the
better, since it's more likely to be correct---but I'll make the
indicated changes and attach the patch to a new ticket c/o you.
You'll have to test it, since I'm not running 19 (yet) and thus
won't be able to. (I don't dare even run a 19 FE or BE anywhere
on my network for fear that one misconfiguration anywhere might
cause it to talk to my -real- BE and uprev my database!)
I'll probably be able to get to this Sunday or early next week.
Thanks!
More information about the mythtv-dev
mailing list