[mythtv] [PATCH] Sanity checking in mythtv-setup

Nigel Pearson nigel at ind.tansu.com.au
Tue May 31 01:23:45 UTC 2005


	Several times I have forgotten to set the starting
channel on a card to something that actually exists.
(It defaults to 3, but not everyone has a channel 3)

	I have created new files which contain some checks
for this soft of stuff, and the attached patch calls this
in mythtv-setup when exiting (plus some dialog box tidyup).

Questions:

1) Does anyone think that these sort of checks
    should be called from the frontend too?
    (e.g. after changing stuff in the setup pages)
    If so, then the new files should probably
    live in libmythtv instead of setup

2) This code creates a few MSqlQueries,
    which also creates a few database connections.
    Not all of them get deleted automatically
    (which is only a problem if the user keeps
     making mistakes and setup keeps re-checking).
    Any suggestions for fixing this? I'm stumped.


If no dissent in a week or so, I will commit as-is.

% cvs diff -u setup/main.cpp setup/setup.pro >../patch.general.15

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.general.15
Type: application/octet-stream
Size: 4483 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050531/b9333310/patch.general.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: checksetup.cpp
Type: application/octet-stream
Size: 4486 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050531/b9333310/checksetup.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: checksetup.h
Type: application/octet-stream
Size: 139 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050531/b9333310/checksetup-0001.obj
-------------- next part --------------


--
Nigel Pearson, nigel at ind.tansu.com.au|"Beware - I am a carrier
Telstra BI&D, Sydney, Australia      |          of surrealism"
Office: 8255 4222    Fax:  8255 3153 |  D  A
Mobile: 0408 664435  Home: 9792 6998 |  L  I



More information about the mythtv-dev mailing list