[mythtv] [PATCH] mythgallery: move .thumbcache out of image directory

[Ed W]

> One thing I was wondering about, though: If the code falls back to  
> ~/.mythtv when the gallery dir is read-only, do we still need the  
> checkbox?  Wouldn't it be enough to mention it in the docs that if  
> you don't like .thumbcache dirs, you should not give the mythtv user  
> write access to the image dir?


I prefer the ability to use the check box to *force* it as you argued 
for earlier.  I prefer to keep my huge collection of photos with minimal 
chance of being buggered up by some app which goes a bit bonkers.  
Forcing the thumbnails into another directory helps a bit (and will be a 
bit faster because we don't have to waste time doing an system("mkdir 
xxx") all the time.)

The use of the "system()" function is a security hole though...  One 
appears to be able to craft a directory name which will then cause local 
execution of some command when it's executed...  I think the string 
needs to be pre-escaped or more likely there is a QT mkdir function.  Do 
you think you could research this and supply a patch?

Thanks and good luck

Ed W

P.S. Next patch is to tidy up the code I have here which rescales the 
images if you have a screen with widescreen aspect ratio.  Stops people 
looking really fat... It's only 5 lines, but I never seem to have time 
to finish it off...