[mythtv] Re: [PATCH] EPG Improvements

[Harvard Pan]

Many thanks to Brian Huffman for testing my patch and finding serious
issues after I introduced the dialog. Hopefully, I've worked out the
kinks. I have put a new version of the diff on my web site.

The new file location is:

http://home.comcast.net/~harvardpan/EPGUpdated5112005.diff.bz2

If anyone finds anything wrong with the patch, I'd appreciate feedback
so that I can resolve it as soon as possible.

Thanks!
Harvard

On 5/10/05, Harvard Pan <harvardpan at gmail.com> wrote:
> Alright, I've put in the dialog and posted it on my web site. You can
> grab it from:
> 
> http://home.comcast.net/~harvardpan/EPGUpdated05102005.diff.bz2
> 
> In it, I have the dialog coming up when the channel is unavailable.
> FYI, since the check for an available recorder happens before the
> current player is stopped, it may seem like the system is a bit
> sluggish when changing channels on remote backends. I think it's an
> acceptable wait time, but please let me know if someone disagrees.
> 
> Also, I finally tracked down the SEGFAULT that occurs when some popup
> dialogs happen from within the TV object. The reason for the segfault
> is that the program guide is run from a forked thread inside the TV
> object. However, when an error occurs in the TV object, a method in
> mythfrontend's main.cpp calls "delete tv". The TV object is
> destructed, but the program guide is still running. When the program
> guide destructs, it returns the context to an already destroyed
> parent, which causes the crash. I've fixed the crash by checking
> tv->IsMenuRunning() and making sure that if a menu is running, we
> don't delete. Please pick up the changes from main.cpp to fix this
> crash.
> 
> --Harvard