[mythtv] DVB Patches Applied from last few weeks. Anything missed?

Taylor Jacob rtjacob at earthlink.net
Sun Mar 27 18:27:24 UTC 2005


Quoting Torbjörn Jansson <torbjorn.jansson at mbox200.swipnet.se>:

> Here is the patch.
> It contains the missing code to insert the credits and it adds a new check
> to eitfixup4 that tries to separate subtitle from description for some
> channels.
> This check can't be run on all channels or it woud cause problems, so i
> added a new entry to dtv_privatetypes that is a list of ServiceIDs.

Its all commited.  Sorry I missed it last time.. Just blame John.. :)

> To make it work this needs to be inserted into the database:

Can you please include a dbcheck.cpp diff next time.. Would make applying this
stuff much easier..

> There is still room for improvments, but maybe the fixup function is geting
> a bit large :-)

As long as it does something useful I am OK with it.  Eventually we might need
to look for commonality in all the fixup scripts and clean it up that way, but
for now its OK..  No need for a refactor yet..  I can already see a few that
split the title into subtitle via some deliminator.. No need for that more than
once..

> For example the guide data for hallmark begins with lots of crap like
> category, year, a list of actors and director, length and then if i'm lucky
> i get one or 2 words from the real "description" of the program.

<snip>

> But i guess i'll have to wait until the segmented eit thing is fixed
> (description is realy long and gets cutoff right at the intresting part)
> before considering doing anything to it.

What do you mean segmented eit?  Segmented EIT is a way the table and sections
are handled.. Do you mean your extended text descriptors need to be
concatenated in some way?  If so please feel free to send a patch for this,
since I don't have anything like that here at all..

Taylor


More information about the mythtv-dev mailing list