[mythtv] [PATCH] Fix (now broken) screen settings

Nigel Pearson nigel at ind.tansu.com.au
Wed Mar 23 01:34:29 UTC 2005


> But you might have to do some work on DisplayResOSX.cpp.
...
> I made the needed changes to DisplayResOSX, and flushed out that
> implementation by implementing GetDisplaySize(). But I don't have
> a MacOSX system to compile on so this may not even compile.

	Indeed it didn't :-)

	Attached patch fixes these, takes out the un-necessarily
added #ifdef X11 GetMythTVGeometry() in util.h, and adds a
few frameworks to mythtv.pro.


> There are also a couple calls that I wasn't clear on from reading
> the spec, these are marked with my question and "-- dtk"

	Just the CFReleases, right? I thought they would be needed,
but adding them caused the app to crash somewhere in CoreGraphics
when opening the screen, so it looks like they shouldn't be there.


	Overall:
1) I haven't really had time to test your new code at all

2) Not sure about the changes in util.cpp/h

2a) GetNumberOfXineramaScreens() could easily be replaced
with Qt's QApplication::desktop()->numScreens(),
which also works on OS X, Windows, et c.

2b) I was trying to keep util.cpp as a set of "utility"
sort of code (i.e. OS and file sort of stuff), hence the
removal of the X11 specific stuff in my multiscreen patch.
GetDisplayModes() maybe belongs elsewhere?
(But mythcontext is getting crowded,
  so I don't know where else to put it)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.general.12
Type: application/octet-stream
Size: 4538 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050323/dcb32dc7/patch.general.obj
-------------- next part --------------


--
Nigel Pearson, nigel at ind.tansu.com.au | "People say I'm strange, does it
Telstra BI&D, Sydney, Australia       |        make me a stranger?
Office: 8255 4222    Fax:  8255 3153  |  My best friend was born
Mobile: 0408 664435  Home: 9792 6998  |         in a manger"    -DC Talk



More information about the mythtv-dev mailing list