[mythtv] mythtranscode "missing" cutpoints

[Jack Wrobbel]

On Wed, 2005-03-16 at 01:29, Chris Petersen wrote:
> I'm running CVS from 3/9, and have noticed that recently a number of my 
> recordings still have commercial chunks in them after I run them through 
> nuvexport (via mythtranscode).
> 
> Now, I've always had issues with mythtranscode (and mythtv in general) 
> reporting the incorrect frame number for the closing cutpoint (something 
> I'd really like to see fixed), but usually the middle cutpoints are 
> handled properly.
> 
> As far as I can tell, this is a mythtranscode issue.  In the cutlist 
> editor, the cutpoints all look fine, and ffmpeg merely encodes exactly 
> what mythtranscode sends it (doesn't have its own cutpoint handling that 
> I can find, or I'd be using it).  Initially, I'd guess that this has 
> something to do with mythtranscode wanting to wait for key frames or 
> something like that, but I've had it send whole commercial segments for 
> a show (only the first cut is honored).
> 
> I haven't seen any related commits go in, so does anyone have any 
> suggestions on what I can do to debug this issue?
> 
> -Chris
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev


I think there needs to be a call to UpdateFramesPlayed in the GetFrame
function for each decoder.  Below is the diff for my nuppeldecoder.cpp
file.  

The same thing may be necessary for the other decoders.

  Jack.


Index: nuppeldecoder.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/nuppeldecoder.cpp,v
retrieving revision 1.64
diff -u -r1.64 nuppeldecoder.cpp
--- nuppeldecoder.cpp   23 Feb 2005 05:04:36 -0000      1.64
+++ nuppeldecoder.cpp   17 Mar 2005 03:01:11 -0000
@@ -1110,6 +1110,10 @@
     }
 
     framesRead = framesPlayed;
+/* jmw start */
+    UpdateFramesPlayed();
+/* jmw end */
+
 
     return true;
 }