[mythtv] MythGame bug

[Barney Barumba]

> On Sun, Mar 13, 2005 at 06:58:41PM -0800, Joe Votour wrote:
>>I knew that I forgot to post something to the list
>>after 0.17 came out...
>>
>>Actually, if "system" isn't part of the categories for
>>me, then MythGame crashes.
>>
>>Also, if you don't put "date" in the categories, then
>>you'll see a date value of "0" for every game.
>>
>>Perhaps if I get some time, I'll take a look at it,
>>but no guarantees.
>>
>>-- Joe
>
> Attached is a patch which fixes this for me. It ends up having to touch
> quite a lot of files, and the fix is more of a bandaid (as the proper
> fix IMHO would be to remove all the instances of
> "setting-parameters-via-parent" stuff from mythgame, but that is a much
> larger change).
>
> Since a "proper" fix will be much more upsetting, I suggest that this
> one is applied to CVS after it gets some testing.
>
> Joe, can you test if it fixes the problems you're seeing?
>
> Regards,
> David
>
> patch diffstats:
>  atarihandler.cpp    |    5 ++++
>  atarihandler.h      |    1
>  atarirominfo.h      |   11 ++++++++-
>  gamehandler.cpp     |   25 +++++++++++++++++++++
>  gamehandler.h       |    3 ++
>  gametree.cpp        |   60
> ++++++++++++++++++++++++++++++++--------------------
>  mamehandler.cpp     |    5 ++++
>  mamehandler.h       |    1
>  neshandler.cpp      |    5 ++++
>  neshandler.h        |    1
>  nesrominfo.h        |    9 +++++++
>  odyssey2handler.cpp |    5 ++++
>  odyssey2handler.h   |    1
>  odyssey2rominfo.h   |    9 +++++++
>  pchandler.cpp       |    5 ++++
>  pchandler.h         |    1
>  sneshandler.cpp     |    5 ++++
>  sneshandler.h       |    1
>  18 files changed, 129 insertions(+), 24 deletions(-)
>
>
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>

Hi,

I noticed this problem a couple of weeks ago, and posted a suggested patch
(around March 2nd - subject "mythgame seg fault with custom levels"). This
was a patch against 0.17 not CVS, but it worked for me. It should be easy
to change for current CVS, as it only touches gametree.cpp.

As mentioned in my previous message, I've also been playing with
re-writing the favourites code. As I got no replies to the last message I
assumed nobody was interested in this, so it's not been at the top of my
list. It's quite a few changes to gametree.cpp, but only one other change
outside of that - can't remember where OTTOMH as I'm at work at the mo and
don't have the code handy.

If anyone is interested in the new favourites ideas I'd be happy to
discuss them and come up with something that we can put back into myth. If
not, I'll just do them for myself - that's the beauty of open source :-)

Cheers,

Barney.