[mythtv] [PATCH] Fix (now broken) screen settings

[Bruce Markey]

Nigel Pearson wrote:
...
>>  However, I'd recommend applying this as the current
>> CVS behavior is not correct.
> 
> 
>     I am tempted to leave it another day or two for others
> to check, but I guess there is no-one else reading this thread,
> so OK - in it goes.

The corollary to 'if it ain't broke don't fix it' is 'if it
is broke, fix it'. There is a tenancy to get timid when
changes introduce new problems but it should be more desirable
to move forward to resolve those problems. In this case, there
is a greater than 0% chance that this may have a new bug that I
didn't find but there is a 100% chance that the behavior in CVS
was not correct so I think you did the right thing.

>     I also have one more method planned in mythcontext.cpp,
> for my future command-line geometry parsing changes.
> I may slip the method signature and empty method in now,
> so that adding the new code will not require an annoying
> recompile of everything that depends on mythcontext.h

In general, I like the fact that you've taken on cleaning this up.
There is still a lot of obfuscation due to several things added
by different people at different times. Command-line geometry
parsing would be good. Adding a key binding to switch between
GUI size and fullscreen during playback would be nice too. We used
to have this but it got lost in the shuffle somewhere around 0.9.

--  bjm