[mythtv] [PATCH] Fix (now broken) screen settings

[Bruce Markey]

Nigel Pearson wrote:
> [My multiple screen sanity, simplify X11 screen settings, patch]
> 
>> This doesn't seem to do the right thing WRT GuiSizeForTV=0 .
>> If on, it should playback in the same space as the GUI. Turning
>> off this option should use fullscreen for TV playback.

>     OK. Problem not evident on Max OS X, but it is on linux.

I'm surprised. When you set your GUI size smaller than full screen
and not in the upper left, turned off GuiSizeForTV then started
playback, what happened? How could your Mac find the correct screen
dimensions?

>     Fixing this was harder than expected. It involved some
> structural changes in mythcontext.cpp, which will need some
> review and more thorough testing.

Will do.

>     The attached patch has a new method,
> MythContext::GetScreenBounds(...), which returns the dimensions
> of the full screen. tv_play.cpp now uses this, instead of
> getScreenSettings(...), which returned the GUI dimensions,
> or the original X11-specific GetMythTVSettings().

First problem was that the window size and shape was wrong:

2005-03-08 10:51:33.813 REQUESTED DIMENSIONS 0,0: 1400x1050
2005-03-08 10:51:33.813 RECEIVED DIMENSIONS 0,1400: 0x1050

This was because the args were in the wrong order in mythcontext.cpp


+void MythContext::GetScreenBounds(int &xbase, int &width,
+                                  int &ybase, int &height)

Should have been:

void MythContext::GetScreenBounds(int &xbase, int &ybase,
                                  int &width, int &height)

and was correct in mythcontext.h and tv_play.cpp though the
int declarations are in the wrong order. Not sure how you mixed
up the version that you built and verified as working then made
a patch that could not have worked. A little more care could have
saved time =).

Next, it now creates a 1400x1050 X window but the playback is
still 0,0 640x480 with the remainder of the screen having the
background image tiled. Could you try this in your test environment
and resolve it?

--  bjm