[mythtv] [PATCH] fix avformatdecoder busyloop

Mark Spieth mark at dclabs.com.au
Tue Jun 21 23:48:59 UTC 2005


not the correct fix. still compare selectedTrack but use ==-1 to check
whether a track has been found not the > maxTracks.
I missed the 2nd comparison though so that was a good find.
patch attached for 2nd one otherwise would fail badly if no track is found.
cheers
mark

--- avformatdecoder.cpp 3 Jun 2005 18:21:36 -0000       1.151
+++ avformatdecoder.cpp 21 Jun 2005 23:47:42 -0000
@@ -1361,13 +1493,13 @@
                 }
             }
         }
-        if (selectedTrack > maxTracks)
+        if (selectedTrack == -1)
         {
             minChannels--;
         }
     }

-    if (selectedTrack  > maxTracks)
+    if (selectedTrack == -1)
     {
         VERBOSE(VB_AUDIO,
                 QString("No suitable audio track exists."));

>>>>>>>>>>>>>>>>>>>>>
Guess if there is no valid audiostream, we get stuck at
AvFormatDecoder::autoSelectAudioTrack.

It is possible the fix is not correct one, but there is definitely busyloop
there.

Patch against CVS HEAD.

-- 
Markus Linnala




More information about the mythtv-dev mailing list