[mythtv] [PATCH] mythvideoupdate v1

Mark Spieth mark at dclabs.com.au
Sat Jun 4 07:41:41 UTC 2005


> Great functionality, have something like this in my tree.
>
> Your patch duplicates the VideoScanner code, which is a burden for code
> maintenance. Wouldn't it better to:
> - make VideoScanner in mythvideo gui (in)dependent depending from where
> it is called
> - put VideoScanner in a separate lib, or link against the mythvideo lib
> (the latter being less nice since it's not installed in the default
libpath)
>
you are of course correct. I did say it was quick and dirty.
my other choice was to do a conditional compile removing the
mythprogressdialog bits.
that is the easiest way to share the code from videoscan.cpp.
this will do though. =)
cheers
mark



More information about the mythtv-dev mailing list