[mythtv] [PATCH] mythvideoupdate v1

Paul Koster mythtv at kosteronline.net
Sat Jun 4 07:20:48 UTC 2005


Mark Spieth wrote:
> attached is a quick and dirty patch that updates mythvideo db from the 
> command line.
> so no more having to enter setup/videomanager to do this =)
> usage mythvideoupdate
> installs in the bin dir.
> this patch adds a new dir that generates the app.

Great functionality, have something like this in my tree.

Your patch duplicates the VideoScanner code, which is a burden for code 
maintenance. Wouldn't it better to:
- make VideoScanner in mythvideo gui (in)dependent depending from where 
it is called
- put VideoScanner in a separate lib, or link against the mythvideo lib 
(the latter being less nice since it's not installed in the default libpath)

--
Paul


More information about the mythtv-dev mailing list