[mythtv] [PATCH] DBOX2 Feed Implementation 2005-05-10

[John Pullan]

On Thu, 2005-06-02 at 12:34 +1000, Andrew wrote:
> On Tuesday 31 May 2005 00:07, fred dibnah wrote:
> > Brilliant thankyou very much Andrew it's a top feature
> > I hope it makes it to cvs!
> >
> > --- Andrew <atp4 at optusnet.com.au> wrote:
> > > On Monday 30 May 2005 22:18, fred dibnah wrote:
> > > > Guys I can't even get this to compile with todays
> > >
> > > cvs
> > >
> > > > on fedora core 3
> > > >
> > > > In file included from tv_rec.cpp:47:
> > > > dbox2recorder.h:41: warning: direct base `QObject'
> > > > inaccessible in `DBox2Recorder' due to ambiguity
> > > > dbox2recorder.h: In member function `QObject*
> > > > DBox2Recorder::qObject()':
> > > > dbox2recorder.h:42: error: `QObject' is an
> > >
> > > ambiguous
> > >
> > > > base of `DBox2Recorder'
> > > > tv_rec.cpp: In member function `bool
> > >
> > > TVRec::Init()':
> > > > tv_rec.cpp:155: error: cannot allocate an object
> > >
> > > of
> > >
> > > > type `DBox2Channel'
> > > > tv_rec.cpp:155: error:   because the following
> > >
> > > virtual
> > >
> > > > functions are abstract:
> > > > channelbase.h:61: error:  virtual int
> > > > ChannelBase::GetFd()
> > > > make[2]: *** [tv_rec.o] Error 1
> > > > make[2]: Leaving directory
> > > > `/mnt/shared/data/daves/mythtv/libs/libmythtv'
> > > > make[1]: *** [sub-libmythtv] Error 2
> > > > make[1]: Leaving directory
> > > > `/mnt/shared/data/daves/mythtv/libs'
> > > > make: *** [sub-libs] Error 2
> > > >
> > > > I'm using fedora core 3 and the latest updated
> > >
> > > patch
> > >
> > > > Do you have any ideas?
> > >
> > > Im having a look at the moment. Its strange, as
> > > nothing I can see changed too
> > > much, but I am no expert. I let you know when I work
> > > it out.
> > >
> > > Andrew
> > > _______________________________________________
> Ok, I got it working again, Ive given it a good test and it seems to be ok, 
> now Im no expert so im not sure what ive done is correct but it works. 
>  I also had to change a line in channelbase.h line 60 from 
> virtual int GetFd() = 0; to virtual int GetFd() { return 0; }
> as posted by Devan Lippman. 
> Also changed the schema to 1086.
> 
> Andrew. T
> 

Not looked at the code here but it seems to me that channelbase.h should
remain the same i.e abstract, but the definition of GetFD should be made
in DBOX2Channel ?

Regards
--
John