[mythtv] [patch] AC3 patches

[Isaac Richards]

On Thursday 27 January 2005 10:32 pm, Tim Davies wrote:
> Isaac Richards wrote:
> >On Thursday 27 January 2005 08:25 pm, Tim Davies wrote:
> >>Isn't CheckAudioParams running on what could possibly be a new stream?
> >>Which means the codec could change, and therefore avcodec_find_decoder
> >>and avcodec_open need to be called in CheckAudioParams?  It actually has
> >>to verify that the codec has changed, and not rely on a sample_rate or
> >>channels change.  We mostly have Dolby 2.0 which has the same channels
> >>and sample_rate as MPEG2 audio.
> >
> >All the codecs are already open at that point (from ScanStreams).  No need
> > to open them again.  CheckAudioParams is for informing the NVP about what
> > avformatdecoder is sending it, and reopening the codec on an audio format
> > change, since most of them don't handle that gracefully in libavcodec. 
> > The NVP object doesn't care what the codec was.
>
> But it does need to do SetupAudioStream if the codec changes...

For what?  The ac3passthrough stuff?  That could be accomplished in a much 
less intrusive & nicer way than going through CheckAudioParams.  I'd accept a 
patch like that.

Isaac