[mythtv] delete vs delete[] in dvbrecorder destructor
John Pullan
jmp at tarantella.com
Tue Feb 22 12:33:04 UTC 2005
On Tue, 2005-02-22 at 20:22 +0800, Tj wrote:
> John Pullan wrote:
>
> >These should be delete[]'s
> >
> >
> Does it really make a difference?
I can't remember if it affects gcc (getting old) , but it does cause
memory fault issues for other compilers.
>
> I did a backtrace and mythbackend appears to crash at dvbrecorder:341
> and a corrupted stack error. Is the corrupted stack caused by delete or
> is it because of something else (e.g. gcc optimisations)?
>
Well it's wrong and I have seen it break other things.
> Also changed 'Iterator es' to 'const_iterator es' in the hopes it may
> stop mythbackend from crashing my machine occassionally after finishing
> a recording (and also a little bit faster).
>
dunno
> Attached is a simple patch for anyone who is interested to test this
> out/look at.
<snip>
I'd vote for commiting this (as if my vote counts :p )
More information about the mythtv-dev
mailing list