[mythtv] Re: Re: Re: 0.17 playback on PVR-350 tvout has bad framecount timing

Derek Atkins warlord at MIT.EDU
Thu Feb 17 01:02:27 UTC 2005


Okay, now I'm really confused...

When I use "-1" (or 0) my patch works great.  When I use "-2" (to save
two extra bytes at the end of the buffer) it does not work.  I.e., my
first patch and second patch work fine for me, but the third patch
does not work.

-derek

Derek Atkins <warlord at MIT.EDU> writes:

> Actually, don't commit this patch..  It doesn't work for pre-recorded
> programs.  How weird.  I'm testing something else at the moment to
> make sure.
>
> -derek
>
> Derek Atkins <warlord at MIT.EDU> writes:
>
>> David Engel <gigem at comcast.net> writes:
>>
>>>> *sigh*.  So on average you lose the count of one frame ever 18 minutes...
>>>
>>> I know, but it's still a bug!
>>
>> True, but it's much lesser of an evil than the current code.  The
>> current code is nearly unusable watching LiveTV.  But eh, I don't have
>> commit access.
>>
>>>> Perhaps something like the attached patch?  I think this will do the
>>>
>>> Yes, like that, but I think you need to allow for a 2-byte pad.
>>> bufptr is incremented before we access bufptr[1], so it's actually the
>>> second byte after the end of buffer check.
>>
>> picky picky picky.  Here's another version with some updated comments.
>>
>> -derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available


More information about the mythtv-dev mailing list